Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fbc v3 fixes #264

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Fbc v3 fixes #264

merged 1 commit into from
Aug 12, 2022

Conversation

skeating
Copy link
Member

@skeating skeating commented Aug 6, 2022

Use new branch gh was caching old expat I think

Description

Fix fbc v3 issues

Motivation and Context

Fixes #256
Fixes #255
Fixes #251
Fixes #257

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@skeating skeating requested a review from fbergmann August 6, 2022 12:33
@fbergmann fbergmann merged commit cddb542 into development Aug 12, 2022
@fbergmann fbergmann deleted the fbc-fixes branch August 12, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbergmann fbergmann fbergmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@skeating @fbergmann