-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't add ModelHistory without dates even in L3V2 #290
Comments
is it possible to call |
For the exact issue I guess we could fix it by setting (and unsetting it after the check) the parent before calling Line 2256 in 226c867
If someone wants to call Another option would be to pass the SBML version as a parameter to |
i think that is could idea, if no parent has been set, we temporarily set before the check, and unset after. |
Thanks for fixing! |
#265 adds support for
ModelHistory
without dates in L3V2.However, when running the
addModelHistory.c
example with the parts adding the dates commented out on a L3V2 SBML file, we still get the following output:Set model history: invalid object
.The reason for that is that
ModelHistory::hasRequiredAttributes
is called on a model history which does not have a parent SBML object (yet) so we are falling in thelevel < 3
branch here:libsbml/src/sbml/annotation/ModelHistory.cpp
Line 382 in 226c867
The text was updated successfully, but these errors were encountered: