Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax annot #265

Merged
merged 5 commits into from
Aug 12, 2022
Merged

Relax annot #265

merged 5 commits into from
Aug 12, 2022

Conversation

skeating
Copy link
Member

@skeating skeating commented Aug 8, 2022

Description

Make dates optional on ModelHistory for l3

Motivation and Context

Fixes #259

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@skeating skeating requested a review from fbergmann August 8, 2022 10:09
@fbergmann fbergmann merged commit 326a82a into development Aug 12, 2022
@fbergmann fbergmann deleted the relax_annot branch August 12, 2022 08:50
@avandecreme avandecreme mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbergmann fbergmann fbergmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createdDate and modifiedDate should be optional attributes on ModelHistory
2 participants
@skeating @fbergmann