Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#241:issues with fbc v3 #243

Merged
merged 3 commits into from
Jul 15, 2022
Merged

#241:issues with fbc v3 #243

merged 3 commits into from
Jul 15, 2022

Conversation

fbergmann
Copy link
Member

Description

in #241 matthias noticed a couple of inconsistencies.

  • need to ensure correct package version is passed along
  • the xmlns on the list of key value pairs is wrong.

Motivation and Context

fixes #241

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann marked this pull request as ready for review July 15, 2022 06:49
@fbergmann
Copy link
Member Author

i've confirmed that all issues are adressed, and working (here a colab book: https://colab.research.google.com/drive/1WTkKmnk8dbJ1NoMedlc91gitDdc2-P8U?usp=sharing) and corresponding python wheels for it. https://github.com/sbmlteam/python-libsbml/actions/runs/2675478034

@fbergmann fbergmann merged commit cb42f00 into development Jul 15, 2022
@fbergmann fbergmann deleted the fbc-v3-fix branch July 15, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fbc-v3: Can't set xmlns on KeyValuePairList & Can't set key and value on KeyValuePair
1 participant