Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use . to access convertStringToXMLNode #272

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Conversation

fbergmann
Copy link
Member

fixes #271

Description

even before using the newer swig it is possible to use . to access the function, so it is fine to just use that.

Motivation and Context

fixes #271

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@skeating skeating merged commit bd170ee into development Sep 24, 2022
@skeating skeating deleted the fbergmann-patch-1 branch September 24, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libsbml test failed with upcoming SWIG 4.1.0
2 participants