Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autotools config for better platform detection #273

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

tom91136
Copy link
Contributor

Description

This change updates the platform detection for autotools, as hinted by the failure itself:

> ./configure
# ....
This script, last modified 2008-12-19, has failed to recognize
the operating system you are using. It is advised that you
download the most up to date version of the config scripts from

  http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD
and
  http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD

Motivation and Context

On an aarch64 Linux machine, running ./configure shows the error in the previous section.
I guess aarch64 isn't really a thing back in 2008.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

I've tested the change on both x86_64 and aarch64, the build completed correctly with the change.

Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the submission.

Note however, that we are in the process of phasing out the autotools build. Several configuration options such as support for SBML packages (supported by the cmake build) are not available with the makefiles. So we recommend using the cmake build.

@fbergmann
Copy link
Member

I'll skip the CI step, as we dont have any scripts testing the gnumake build.

@fbergmann fbergmann merged commit 6135015 into sbmlteam:development Sep 29, 2022
@tom91136
Copy link
Contributor Author

That's good to hear. I now see the section on CMake in the website, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants