Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- ubuntu 18.04 no longer supported #285

Merged
merged 3 commits into from
Jan 12, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/brief.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
platform: [windows-latest, macos-latest, ubuntu-18.04]
platform: [windows-latest, macos-latest, ubuntu-latest]
xml_parser_option: ["-DWITH_EXPAT"]
with_namespace: ["True"]
strict: ["True"]
Expand Down Expand Up @@ -75,9 +75,10 @@ jobs:

- name: Install Ubuntu dependencies
# ubuntu already has SWIG and libxml2 by default
if: matrix.platform == 'ubuntu-18.04'
if: matrix.platform == 'ubuntu-latest'
shell: bash
run: |
sudo apt-get update
sudo apt-get install -y check ccache
echo PYTHON_LINKING_OPTION="-DPYTHON_USE_DYNAMIC_LOOKUP=ON" >> "${GITHUB_ENV}"
echo R_BINDINGS="-DWITH_R=True" >> "${GITHUB_ENV}"
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/extensive.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
fail-fast: false
matrix:
xml_parser_option: ["-DWITH_LIBXML"]
platform: [windows-latest, macos-latest, ubuntu-18.04]
platform: [windows-latest, macos-latest, ubuntu-latest]
with_namespace: ["True", "False"]
strict: ["True"]
with_examples: ["True"]
Expand Down Expand Up @@ -64,14 +64,14 @@ jobs:
language_bindings: ""
# extra Ubuntu runs
- xml_parser_option: "-DWITH_EXPAT"
platform: ubuntu-18.04
platform: ubuntu-latest
with_namespace: "True"
strict: "True"
with_examples: "True"
package_option: "-DWITH_ALL_PACKAGES=ON"
language_bindings: ""
- xml_parser_option: "-DWITH_XERCES"
platform: ubuntu-18.04
platform: ubuntu-latest
with_namespace: "True"
strict: "True"
with_examples: "True"
Expand Down Expand Up @@ -135,9 +135,10 @@ jobs:

- name: Install Ubuntu dependencies
# ubuntu already has SWIG and libxml2 by default
if: matrix.platform == 'ubuntu-18.04'
if: matrix.platform == 'ubuntu-latest'
shell: bash
run: |
sudo apt-get update
sudo apt-get install -y check libxerces-c-dev expat ccache
echo PYTHON_LINKING_OPTION="-DPYTHON_USE_DYNAMIC_LOOKUP=ON" >> "${GITHUB_ENV}"
git clone https://github.com/libexpat/libexpat
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/store-artefact.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
platform: [windows-latest, macos-latest, ubuntu-18.04]
platform: [windows-latest, macos-latest, ubuntu-latest]
xml_parser_option: ["-DWITH_EXPAT=ON"]
with_namespace: ["True"]
strict: ["True"]
Expand Down Expand Up @@ -88,9 +88,10 @@ jobs:

- name: Install Ubuntu dependencies
# ubuntu already has SWIG but expat is too old
if: matrix.platform == 'ubuntu-18.04'
if: matrix.platform == 'ubuntu-latest'
shell: bash
run: |
sudo apt-get update
sudo apt-get install -y check ccache
echo PYTHON_LINKING_OPTION="-DPYTHON_USE_DYNAMIC_LOOKUP=ON" >> "${GITHUB_ENV}"
git clone https://github.com/libexpat/libexpat
Expand Down Expand Up @@ -245,7 +246,7 @@ jobs:
if-no-files-found: error

- name: Upload Ubuntu binary archive
if: matrix.platform == 'ubuntu-18.04'
if: matrix.platform == 'ubuntu-latest'
uses: actions/upload-artifact@v2
with:
name:
Expand Down