Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Java Testrunner #292

Merged
merged 1 commit into from
Jan 12, 2023
Merged

fix Java Testrunner #292

merged 1 commit into from
Jan 12, 2023

Conversation

fbergmann
Copy link
Member

Description

This commit changes the auto test runner to include tests from sub directories, rather than just test. While previous javac versions compiled the old version without issue, newer javac compilers raise an issue. it was originally submitted by @pgrt

Motivation and Context

The change is needed, to get the java bindings built with newer javac, as it otherwise will fail when compiling the tests.
the change still works for older javac versions as well.

fixes #281

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

this will be tested on a run of the extensive checks.

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann merged commit aa9e6e7 into development Jan 12, 2023
@fbergmann fbergmann deleted the fix-java-testrunner branch January 12, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Java imports in AutoTestRunner, version 5.19.7
2 participants