Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- add compile option for mxArrayToString #301

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

fbergmann
Copy link
Member

Description

To support older matlab versions, it would be good to be able to switch between the use of
mxArrayToString and mxArrayToUTF8String. This PR adds a configuration option
WITH_MATLAB_UTF8STRING that is on by default.

Motivation and Context

compile on older matlab

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann requested a review from skeating March 13, 2023 13:00
@fbergmann fbergmann marked this pull request as ready for review March 13, 2023 13:00
@fbergmann fbergmann merged commit b51d7ca into development Mar 14, 2023
@fbergmann fbergmann deleted the matlab-compile-option branch March 14, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants