Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#232: allow to store maps for each model #302

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

fbergmann
Copy link
Member

Description

SBML Transforms so far was only using one set of values. Which caused issues when using multiple models at the same time.
this pr includes a map allowing values to be stored for multiple models.

Motivation and Context

fixes #232

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann requested a review from skeating March 14, 2023 12:43
@fbergmann fbergmann marked this pull request as ready for review March 14, 2023 12:43
@fbergmann fbergmann merged commit 12a8bcf into development Mar 16, 2023
@fbergmann fbergmann deleted the issue-232-allow-multiple-maps branch March 16, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBMLTransforms thread safety
2 participants