Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IdList support in bindings #308

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

fbergmann
Copy link
Member

Description

This PR, ensures that calling IdList::at out of bounds throws an exception instead of crashing runtimes. It also adds some convenience wrappers for python to IdList: __len__, __iter__ and getitem`

Motivation and Context

fixes #306

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann requested a review from skeating March 22, 2023 09:34
@fbergmann fbergmann merged commit 9d0c8a2 into development Mar 22, 2023
@fbergmann fbergmann deleted the issue-306-swig-idlist-issues branch March 22, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python crash with idlist.at()
2 participants