Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xmlns in math #310

Merged
merged 5 commits into from
Mar 27, 2023
Merged

Xmlns in math #310

merged 5 commits into from
Mar 27, 2023

Conversation

skeating
Copy link
Member

@skeating skeating commented Mar 25, 2023

Description

adds multi ns to math if it is declared
will also work for any packages

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we are leaking the new namespaces:

  • on setDeclared... we clone the incoming namespace
  • in assignment operator and copy ctor we steal the namespace from the rhs
  • in destructor we dont free it.

the also probably should be an unsetDeclared... function to get rid / free it. as well

Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsetDe... needs to set mNamespaces to NULL after deleting, as otherwise it could be called again, resulting in a double free.

@fbergmann fbergmann self-requested a review March 27, 2023 13:25
@fbergmann fbergmann merged commit bd26abc into development Mar 27, 2023
@fbergmann fbergmann deleted the xmlns-in-math branch March 27, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants