Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xml from file #311

Merged
merged 5 commits into from
Mar 27, 2023
Merged

Xml from file #311

merged 5 commits into from
Mar 27, 2023

Conversation

skeating
Copy link
Member

Description

add function to read xml from file

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@skeating skeating requested a review from fbergmann March 25, 2023 13:01
Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this, i just added xml declaration to the examples. And additionally allow expat / xerces to also parse xml streams without xml declaration, just as we have it for libxml

@fbergmann fbergmann merged commit b2a45a5 into development Mar 27, 2023
@fbergmann fbergmann deleted the xml-from-file branch March 27, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants