Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted setNamesFromIds.cpp example into a python file #312

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

harveymannering
Copy link
Contributor

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@@ -622,7 +622,14 @@ if(WITH_CHECK)
${CMAKE_SOURCE_DIR}/examples/sample-models/from-spec/level-3/enzymekinetics.xml
setIdFromNames.out.xml
)
ADJUST_PYTHONPATH(test_python_setIdFromNames)
ADJUST_PYTHONPATH(test_python_setNamesFromIds)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be still test_python_setIdFromNames for it to work

@skeating skeating marked this pull request as ready for review April 2, 2023 10:30
@skeating skeating merged commit 7000862 into development Apr 3, 2023
@skeating skeating deleted the python-example branch April 3, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants