Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow model history without creator #313

Merged
merged 3 commits into from
Apr 3, 2023
Merged

allow model history without creator #313

merged 3 commits into from
Apr 3, 2023

Conversation

skeating
Copy link
Member

@skeating skeating commented Apr 2, 2023 •
edited

Description

lets a model history withoutcreator be roundtripped

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@skeating skeating requested a review from fbergmann April 2, 2023 10:29
fbergmann
fbergmann approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@skeating skeating merged commit e575643 into development Apr 3, 2023
@skeating skeating deleted the model-hist branch April 3, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbergmann fbergmann fbergmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skeating @fbergmann