This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for opening this again, in the previous code a check was done for
urn:schemas-upnp-org:service:WANIPConnection:1
; That did not work on my router, I later added a check for aPPPIPConnection:1
and only later realised that the trick was there could be multiple of these strings.I modified the code so that search_gateway defaults to the first one found, but added a function that can be used to create a Gateway using a particular control url. I tested this in different networks and it worked in those! :)