Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [POC] Optional fields struct linter #162

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

✨ [POC] Optional fields struct linter #162

wants to merge 7 commits into from

Commits on Sep 23, 2021

  1. cherry-pick: make condition.lastTransitionTime required

    @fabriziopandini @sbueringer
    fabriziopandini authored and sbueringer committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    a118014 View commit details
    Browse the repository at this point in the history

  2. cherry-pick: Add missing optional tag to omitempty fields 

    In an attempt to keep optional and omitempty tags consistent throughout
the code, adding +optional tag to fields that have the omitempty tag.

Signed-off-by: Stefan Bueringer <buringerst@vmware.com>
Co-authored-by: Stefan Bueringer <buringerst@vmware.com>
    @anusha94 @sbueringer
    anusha94 and sbueringer committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    ba37f99 View commit details
    Browse the repository at this point in the history

  3. cherry-pick: Ensure CRD columns and their order are consistent 

    Signed-off-by: Stefan Bueringer <buringerst@vmware.com>
    @sbueringer
    sbueringer committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    6818aff View commit details
    Browse the repository at this point in the history

  4. cherry-pick: remove required marker

    @fabriziopandini @sbueringer
    fabriziopandini authored and sbueringer committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    bfe05d5 View commit details
    Browse the repository at this point in the history

  5. Add API conventions, fix status fields 

    Signed-off-by: Stefan Bueringer buringerst@vmware.com

Co-authored-by: fabriziopandini <fpandini@vmware.com>
    @sbueringer @fabriziopandini
    sbueringer and fabriziopandini committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    1582f78 View commit details
    Browse the repository at this point in the history

  6. Implement struct verifier

    @vincepri @sbueringer
    vincepri authored and sbueringer committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    ba1fb65 View commit details
    Browse the repository at this point in the history

  7. md experiment

    @sbueringer
    sbueringer committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    b8460fd View commit details
    Browse the repository at this point in the history