Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only consider scala source files when lifting fatal errors #2346

Merged
merged 4 commits into from
Jun 19, 2024
Merged

fix: Only consider scala source files when lifting fatal errors #2346

merged 4 commits into from
Jun 19, 2024

Conversation

masonedmison
Copy link
Contributor

@masonedmison masonedmison commented Jun 3, 2024 •
edited
Loading

Closes #2341

masonedmison and others added 2 commits June 18, 2024 20:59
@masonedmison @tgodzik
Use universal path in test assertion
a8c6f9a 
Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
@masonedmison
Merge branch 'main' into 2341
d8d00f6
tgodzik
tgodzik approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@tgodzik tgodzik merged commit e10ec04 into scalacenter:main Jun 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When fatal warnings set Java ones are also shown as errors
2 participants
@masonedmison @tgodzik