Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(fix): bump-up protobufVersion to 3.21.12 (latest) #757

Closed

Conversation

laysakura
Copy link
Contributor

@laysakura laysakura commented Dec 17, 2022

Problem

The following command fails in M1 Mac (osx-aarch_64).

./gradlew :rpc:generateProto  # called from `./gradlew test`, for example
> Task :rpc:generateProto FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':rpc:generateProto'.
> Could not resolve all files for configuration ':rpc:protobufToolsLocator_protoc'.
   > Could not find protoc-3.20.3-osx-aarch_64.exe (com.google.protobuf:protoc:3.20.3).
     Searched in the following locations:
         https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/3.20.3/protoc-3.20.3-osx-aarch_64.exe

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/7.0.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 646ms
3 actionable tasks: 1 executed, 2 up-to-date

This is because the version 3.20.3 does not include protoc binary for osx-aarch_64 in the maven repository, while 3.21.12 does.

Refs: protocolbuffers/protobuf#8062

What I did

Bump up protobufVersion from 3.20.3 to 3.21.12 (latest).

I'm not sure...

The command:

./gradlew :rpc:generateProto

leads to the following diffs. Currently I don't commit the diffs but I will if necessary.

rpc-generateProto.diff.txt

@laysakura
Copy link
Contributor Author

close this fork version in favor of: #760

@laysakura laysakura closed this Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant