fix: improve validation of zone and region args #1122

kindermoumoute · 2020-06-22T15:08:32Z

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

- validate zone and region arguments

internal/core/arg_specs.go

Co-authored-by: Jerome Quere <[email protected]>

feat: validate zone and region arg specs

ff6475b

jerome-quere changed the title ~~feat: validate zone and region arg specs~~ fix: improve validation of zone and region args Jun 22, 2020

jerome-quere previously approved these changes Jun 22, 2020

View reviewed changes

fix message

e9c3d46

kindermoumoute dismissed jerome-quere’s stale review via e9c3d46 June 22, 2020 15:13

jerome-quere suggested changes Jun 22, 2020

View reviewed changes

internal/core/arg_specs.go Outdated Show resolved Hide resolved

internal/core/arg_specs.go Outdated Show resolved Hide resolved

Apply suggestions from code review

494eeaf

Co-authored-by: Jerome Quere <[email protected]>

jerome-quere approved these changes Jun 22, 2020

View reviewed changes

kindermoumoute merged commit 60fce9d into v2 Jun 22, 2020

kindermoumoute deleted the remove-enum-validate-zone2 branch June 22, 2020 15:30

Provide feedback