Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce PHPStan #1276

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Introduce PHPStan #1276

merged 2 commits into from
Jan 13, 2021

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jan 11, 2021

No description provided.

@simPod simPod changed the title Run PHPstan with GA Introduce PHPStan Jan 11, 2021
@simPod simPod force-pushed the phpstan branch 2 times, most recently from 1bb3dc5 to 74244de Compare January 11, 2021 09:49
goetas
goetas reviewed Jan 11, 2021
View reviewed changes
Copy link
Collaborator

@goetas goetas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! i like it!

Can you please have a look at the two comments i've left?

phpstan-baseline.neon Show resolved Hide resolved
phpstan-baseline.neon Outdated Show resolved Hide resolved
@goetas goetas merged commit f91971c into schmittjoh:master Jan 13, 2021
@simPod simPod deleted the phpstan branch January 13, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobion Tobion Tobion left review comments

@goetas goetas goetas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simPod @Tobion @goetas