Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non docblock constructor promoted property #1462

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Handle non docblock constructor promoted property #1462

merged 2 commits into from
Jan 12, 2023

Conversation

dgafka
Copy link
Contributor

@dgafka dgafka commented Jan 12, 2023

This solves: #1460 with test case.

Thanks @simPod for rising issue :)

Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

@dgafka
Copy link
Contributor Author

dgafka commented Jan 12, 2023

@goetas can we merge and release this?

@goetas goetas merged commit e8b252e into schmittjoh:master Jan 12, 2023
@dgafka dgafka mentioned this pull request Jan 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgafka @goetas