Groups doctrine deserialization #812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
August 18, 2017 18:41
continue from the mock context for groups
tests did not performed correctly because of an empty classMetadata
…ding to the other tests. Some refactoring of the tests should be performed too (move something into setup method + removing duplicating setup among other my test methods)
if an identifier is passed but is excluded by the group rules, the fallback objectconstructor is called (doctrine can't find the entity without the id, which must be ignored in this case)
…class for backward compatibility reasons (final class in old versions)
…sues" This reverts commit 702926e
…ity (final class)
|
Hi @goetas Do you have any news on this pull request? Thank you. |
|
Hi, Unfortunately this pr is not implemented in a way that makes it ready to be merged. It works only for annotations (not for yaml or xml metadata). Do you want to resume the work on it? |
|
Implemented in #1246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine's ObjectConstructor ignored the Context groups that can be specified when deserializing. An identifier could be sent and it was used to find an entity, irrespective of its group. This is not a problem if groups are not used while deserializing, but can cause big security concerns if groups are used to not let the user send data that could affect persisted data.
The pull request adds some tests to show it and it tries to fix it without altering the other functionalities.