Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Additional names #11

Closed
thebigcosinus opened this issue Aug 12, 2019 · 6 comments
Closed

Question: Additional names #11

thebigcosinus opened this issue Aug 12, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@thebigcosinus
Copy link

Hi,

Thanks for your great plugins.

Is it possible to add Additional names
I would like my domain to be domain.com and add *.domain.com in additional names.

Is that possible ?

Thanks

@schwamster
Copy link
Owner

Hi @thebigcosinus ,

should be possible -> https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/ACM.html#requestCertificate-property

A new option called subjectAlternativeNames could be added to the configuration with a list of alternative names:

  customCertificate:
    certificateName: 'somedomain.com'
    hostedZoneName: 'somedomain.io.'
    subjectAlternativeNames :
      - 'somedomain.net'
      - 'someotherdomain.com'

Is this what you are looking for?

@thebigcosinus
Copy link
Author

Yes exactly I'm looking for subjectAlternativeNames

@schwamster schwamster added the enhancement New feature or request label Aug 13, 2019
@schwamster schwamster self-assigned this Aug 13, 2019
@schwamster
Copy link
Owner

@thebigcosinus I added a rc for this would you be so kind and see if this will do the trick?

npm i serverless-certificate-creator@rc-SubjectAlternativeNames

@schwamster
Copy link
Owner

fyi - serverless-certificate-creator@rc-SubjectAlternativeNames also contains your other feature request now - certificate name (or rather tags):

so you should be able to test something like this with the current rc

  customCertificate:
    certificateName: 'somedomain.com'
    hostedZoneName: 'somedomain.io.'
    subjectAlternativeNames :
      - 'somedomain.net'
      - 'someotherdomain.com'
    tags:
      Name: 'somedomain.com'
      Environment: 'prod'

@thebigcosinus
Copy link
Author

Hi,
I cannot add additional names. I ve got he error
The request contains an invalid set of changes for a resource record set 'CNAME _....

I ve try différent names
*.mydomain.com
dev.mydomain.com

No success.

Using the aws console I was able to add additional names

@schwamster
Copy link
Owner

Strange. I cannot seem to be able to reproduce your issue. I get it to work with the following configuration

  customCertificate:
    certificateName: 'si10.greenelephant.io'
    idempotencyToken: 'si10greenelephantio'
    hostedZoneName: 'greenelephant.io.'
    subjectAlternativeNames :
      - '*.greenelephant.io'
      - 'dev.greenelephant.io'
    tags:
      Name: 'si10.greenelephant.io'
      Environment: 'prod'

This seems more of an problem with the aws sdk or the selected parameters. Have you checked out if your subjectAlternativeNames are in line with the rules -> https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/ACM.html#requestCertificate-property
Any chance of getting a more detailed error msg and/or your config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants