Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 1.5.0 is broken #34

Closed
Enase opened this issue Mar 1, 2021 · 3 comments
Closed

version 1.5.0 is broken #34

Enase opened this issue Mar 1, 2021 · 3 comments

Comments

@Enase
Copy link

Enase commented Mar 1, 2021

Version is broken due to 755074e (#31 changed code to allow enabling/disabling plugin).

The trouble is here https://github.com/schwamster/serverless-certificate-creator/blob/v1.5.0/index.js#L488

  getCertificateProperty(src) {
    if (!this.enabled) {
      return Promise.resolve('');
    }

this.enabled is always undefined due to the fact that this.initializeVariables(); not called (called right after that).

@schwamster
Copy link
Owner

schwamster commented Mar 1, 2021 via email

schwamster added a commit that referenced this issue Mar 1, 2021
@schwamster schwamster mentioned this issue Mar 1, 2021
Merged
schwamster added a commit that referenced this issue Mar 1, 2021
@schwamster
Copy link
Owner

thx again -> https://github.com/schwamster/serverless-certificate-creator/releases/tag/v1.5.1

@Enase
Copy link
Author

Enase commented Mar 1, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants