-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version 1.5.0 is broken #34
Comments
Thx for reporting. I will get on that as soon as I can
…On Mon, 1 Mar 2021, 16:57 Sergii Kovalev ***@***.***> wrote:
Version is broken due to 755074e
<755074e>
(#31
<#31>
changed code to allow enabling/disabling plugin).
The trouble is here
https://github.com/schwamster/serverless-certificate-creator/blob/v1.5.0/index.js#L488
getCertificateProperty(src) {
if (!this.enabled) {
return Promise.resolve('');
}
this.enabled is always undefined due to the fact that
this.initializeVariables(); not called (called right after that).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#34>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQ3JWS5UVTXI2FABZGB3LDTBO2PRANCNFSM4YMZOWSA>
.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version is broken due to 755074e (#31 changed code to allow enabling/disabling plugin).
The trouble is here https://github.com/schwamster/serverless-certificate-creator/blob/v1.5.0/index.js#L488
this.enabled
is alwaysundefined
due to the fact thatthis.initializeVariables();
not called (called right after that).The text was updated successfully, but these errors were encountered: