Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gamma from the groth16 snark #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imeckler
Copy link

@imeckler imeckler commented Jan 2, 2019

This PR removes gamma from the Groth16 implementation (or put another way, it sets gamma equal to one). The benefit is that it makes the verification key one G2 element smaller, which is a big win from the point of view of proof composition.

From conversations with @arielgabizon, Mary Maller, and independent verification from @vanishreerao, I learned that this term is not actually necessary for any part of the security proof.

@imeckler imeckler changed the title Remove gamma from the groth16 verifier Remove gamma from the groth16 snark Jan 2, 2019
imeckler added a commit to MinaProtocol/mina that referenced this pull request Jan 3, 2019
This PR removes gamma from the Groth16 implementation (or put another way, it sets gamma equal to one). The benefit is that it makes the verification key one G2 element smaller, which is a big win from the point of view of proof composition.

I opened a PR on libsnark [here](scipr-lab/libsnark#137) so hopefully that eventually makes it in upstream, but I want to get this through here first.
@dtebbs
Copy link

dtebbs commented Jul 23, 2019

In r1cs_gg_ppzksnark_generator, don't you need to set G2_gen to one? Otherwise this value needs to appear in the resulting verification key.

dtebbs added a commit to clearmatics/libsnark that referenced this pull request Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants