Release v1.1.3 #54
Merged
Release v1.1.3 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add links to PyPI badges so they link to PyPI instead of the badge image * Tidy up testing & coverage sections now that we've moved to tox * Remove pipenv test & coverage scripts in favor of tox
As currently architected, flake8 requires the checker instance to request at least one argument from: `physical_line`, `logical_line`, or `tree`, otherwise the checker will not be run.
TEST COVERAGE PERFECTION
SebastiaanZ
approved these changes
Dec 19, 2019
MarkKoz
reviewed
Dec 20, 2019
| for function in func_list: | ||
| if function.name == match_name: | ||
| return function | ||
| return [function for function in func_list if function.name == match_name][0] |
There was a problem hiding this comment.
I would have just ignored coverage for that if statement because this change is arguably worse than the original. Anyway, this could be improved, and behave more like the old code, bu using next((...), None).
MarkKoz
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
POSONLYARGStreeargument to the checker so flake8 identifies the plugin as needing to runIn the v1.1.2 release, the
treeinput to the checker was removed in favor of instead requesting the lines of the file to be linted, allowing for a more generic handling of both stdin and file input. Thoughtreewas never used, since the AST from flake8 is untyped, flake8 requires the checker instance to request at least one argument from(physical_line, logical_line, tree)to be present in the checker signature, otherwise the checker will not be run.treehas been readded so we actually lint the files again.A test would be good to have for this scenario so we don't regress in the future, but doesn't need to block the new release while being worked on.