Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation branch #893

Closed
wants to merge 5 commits into from

Conversation

slahirucd7
Copy link

Description

In the readme.md file the logo associated to the product was missing. Therefore I changed it to display the logo.

Related Issue

N/A

Motivation and Context

Since this page gives the first impression to the user, better if repository have the missing logo.

How Has This Been Tested?

This was tested using locally as well as in the GitHub web readme.md web page of the repository.

Screenshots (In case of UI changes):

This how it was displayed before adding the image with new path
image

This how now the product logo is going to be displayed in the repository
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kmehant
Copy link
Collaborator

kmehant commented Mar 7, 2020

Hi thanks for the PR 🌠
Can you make this to the develop branch rather master branch. We don't want to make changes to master branches as we might get conflicts when we merge develop branch ( which is the most updated one) in to master :)

@slahirucd7
Copy link
Author

As requested in the above review note change will be included in the developer branch of the repository. Therefore closing the pull request.

@slahirucd7 slahirucd7 closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants