Skip to content

Commit

Permalink
Remove to-do comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Gallaecio committed May 17, 2024
1 parent 0638df7 commit 763ebfa
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions scrapy_zyte_api/_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,20 +139,13 @@ def build_from_crawler(
class DefaultChecker:

def check(self, response: Response, request: Request):
# TODO: Basic check for the session init only: check if setLocation
# worked, return False if not. If we can tell when setLocation simply
# failed once versus when it is not implemented for the target website,
# raise some exception in the latter case, to indicate that sessions
# for the target website are not supported, avoiding additional
# retries.
return True


class TooManyBadSessionInits(RuntimeError):
pass


# To do: add automatically to the registry by default.
class SessionConfig:

@classmethod
Expand Down

0 comments on commit 763ebfa

Please sign in to comment.