Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LocationSessionConfig with docstrings #215

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

VMRuiz
Copy link
Member

@VMRuiz VMRuiz commented Aug 21, 2024

No description provided.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (a1d81d1) to head (5e771e0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   97.67%   97.69%   +0.01%     
==========================================
  Files          14       14              
  Lines        1551     1564      +13     
  Branches      328      330       +2     
==========================================
+ Hits         1515     1528      +13     
  Misses         15       15              
  Partials       21       21              
Files with missing lines Coverage Δ
scrapy_zyte_api/__init__.py 100.00% <ø> (ø)
scrapy_zyte_api/_session.py 100.00% <100.00%> (ø)

@VMRuiz
Copy link
Member Author

VMRuiz commented Sep 6, 2024

@Gallaecio Is there anything else required here?

@Gallaecio Gallaecio requested review from kmike and wRAR September 9, 2024 07:46
@Gallaecio
Copy link
Contributor

Only a review from someone other than me, as my approval feels like cheating now :)

scrapy_zyte_api/_session.py Outdated Show resolved Hide resolved
scrapy_zyte_api/_session.py Outdated Show resolved Hide resolved
Gallaecio and others added 2 commits September 9, 2024 14:26
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
@Gallaecio Gallaecio merged commit c1ba9c0 into scrapy-plugins:main Sep 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants