Always apply min-height: 0 #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs more work. I'm seeing this in Mac Firefox:
|
|
@benjiwheeler I don't have a mac to test so I'm not sure how that's caused. More details? |
|
@apple502j Sorry, my code version was out of date. I tested again and this looks great! |
benjiwheeler
added
pr - good to merge
and removed
pr - changes requested
pr - needs review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Resolves #3775
Changes:
Always applies
min-height: 0for outer container. See also: https://moduscreate.com/blog/how-to-fix-overflow-issues-in-css-flex-layouts/Test Coverage:
I manually added the CSS on the main website on Firefox and it showed the button as expected. I also tested it on Chrome and it worked just like before.