Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve links to GitHub in documentation #91

Closed
2 tasks done
andrewtavis opened this issue Mar 5, 2024 · 8 comments · Fixed by #102
Closed
2 tasks done

Improve links to GitHub in documentation #91

andrewtavis opened this issue Mar 5, 2024 · 8 comments · Fixed by #102
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Mar 5, 2024

Terms

Description

One thing that would be great for Scribe-Data's documentation would be if the pages were linked to the page where the code was on GitHub rather than the page to edit the docs. I've seen this done for various projects. A Stack Overflow question on this topic that points to helpful docs can be found here.

Contribution

Happy to support someone who has interest in working on this!

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 5, 2024
@mhmohona
Copy link
Collaborator

mhmohona commented Mar 5, 2024

I want to work on this issue.

@mhmohona
Copy link
Collaborator

mhmohona commented Mar 5, 2024

@andrewtavis will you please explain the requirement bit more?
We already have the code linked in doc file here, dont we?

@andrewtavis
Copy link
Member Author

I can look for an example of this, @mhmohona. On some readthedocs documentation that I've seen the top right of the page isn't a link to the documentation that says Edit on GitHub, but rather a page to the code itself. So on the page for utils we'd see View code on GitHub or something like this, and then clicking it would go to utils.py on GitHub.

@mhmohona
Copy link
Collaborator

mhmohona commented Mar 5, 2024

So in simple words, changing this text into View code on GitHub?
image
Thats it @andrewtavis? 😅

@andrewtavis
Copy link
Member Author

andrewtavis commented Mar 5, 2024

Not quite, @mhmohona :) When you click that link you go to the file on GitHub that's for the docs. We want the link to go to the actual code file, so utils.py within src, not within docs.

@mhmohona
Copy link
Collaborator

mhmohona commented Mar 6, 2024

Thank you for patiently explaining me about the issue @andrewtavis. 🙏
I have understood the requirement now.

So I have tried various ways but failing to link customize link (python code file's link) instead of doc link. It would really help if you could give me a reference project as you mentioned in issue description.

However, if I put code link like afkmc2 put, will it meet the purpose?
https://afkmc2.readthedocs.io/en/latest/reference.html

@codeIntrovert
Copy link

codeIntrovert commented Mar 8, 2024

Hi GSOC24 applicant here :)
Looks like this issue is still not fixed, I will try fixing this and let you know how it goes.
From the conversation above what I believe the problem is when user clicks on Edit On Github right now user is redirected to the Docs stored on github, rather user should be redirected to the code file it self, for example utils.py
@andrewtavis

@andrewtavis
Copy link
Member Author

Hi @codeIntrovert: this issue is already assigned to @mhmohona. Could I asked that you look for a different issue?

@mhmohona, having a link below the header would be enough to close this :) This is a great idea, thanks!

@mhmohona mhmohona mentioned this issue Mar 11, 2024
1 task
andrewtavis added a commit to mhmohona/Scribe-Data that referenced this issue Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants