Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub actions workflow to run ci process 499 #500

Conversation

fabulouiOS-monk
Copy link
Collaborator

Contributor checklist


Description

Added .yaml file for running unit test in github workflow.

Related issue

Copy link

github-actions bot commented Sep 3, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@fabulouiOS-monk
Copy link
Collaborator Author

@andrewtavis, The test pipeline is now working fine. But It's taking 8 mins to build and run. Need to see what we can do.

@andrewtavis
Copy link
Member

How are you feeling about it at this point, @fabulouiOS-monk? :)

@andrewtavis andrewtavis self-requested a review September 3, 2024 20:28
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#500! Fitting that it's you sending it along, @fabulouiOS-monk, and also that it's such a major step for Scribe-iOS 😊 Really appreciate your dedication to the project!

Thanks also @vickcoo for the tests here! Really off to a great start!

@andrewtavis
Copy link
Member

Note also that org naming conventions are we name the workflows after the file, but we can talk about this if we would like to give them a title rather than the file :)

@andrewtavis andrewtavis merged commit b29fc0f into scribe-org:main Sep 3, 2024
2 checks passed
@andrewtavis
Copy link
Member

Added a name: to the workflow just now so it's a bit more descriptive :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants