Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable save() method for User and enable SMS manipulation #17

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

ctgraham
Copy link
Contributor

Creates a save() method for the User object and provides mutators for the SMS number.

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@danmichaelo
Copy link
Member

It might seem a bit random to have mutators for just a few of the available user properties, but on the other hand, this aligns quite well with the philosophy behind the rest of this library, which has always been to add abstractions for functionality as-needed rather than aiming for complete coverage of the API, so I'm fine with that :)

@danmichaelo danmichaelo merged commit e27da6c into scriptotek:master Sep 10, 2020
danmichaelo added a commit that referenced this pull request Sep 10, 2020
@ctgraham ctgraham deleted the save-user branch September 11, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants