Skip to content

Commit

Permalink
remove unused return value
Browse files Browse the repository at this point in the history
  • Loading branch information
omerfirmak committed Sep 3, 2024
1 parent 843f5fa commit 024a49c
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions miner/scroll_worker.go
Original file line number Diff line number Diff line change
Expand Up @@ -877,9 +877,9 @@ func copyReceipts(receipts []*types.Receipt) []*types.Receipt {
return result
}

func (w *worker) onTxFailing(txIndex int, tx *types.Transaction, err error) bool {
func (w *worker) onTxFailing(txIndex int, tx *types.Transaction, err error) {
if !w.isRunning() {
return false
return
}

if errors.Is(err, ccc.ErrBlockRowConsumptionOverflow) {
Expand All @@ -893,7 +893,7 @@ func (w *worker) onTxFailing(txIndex int, tx *types.Transaction, err error) bool
tx: tx,
}
}
return true
return
}

// first txn overflowed the circuit, skip
Expand All @@ -903,10 +903,10 @@ func (w *worker) onTxFailing(txIndex int, tx *types.Transaction, err error) bool
log.Warn(
"Unexpected L1 message queue index in worker", "got", tx.AsL1MessageTx().QueueIndex,
)
return false
return
} else if txIndex > 0 {
// If this block already contains some L1 messages try again in the next block.
return false
return
}

queueIndex := tx.AsL1MessageTx().QueueIndex
Expand All @@ -920,8 +920,6 @@ func (w *worker) onTxFailing(txIndex int, tx *types.Transaction, err error) bool
log.Trace("Skipping tx with insufficient funds", "tx", tx.Hash().String())
w.eth.TxPool().RemoveTx(tx.Hash(), true)
}

return false
}

// skipTransaction
Expand Down

0 comments on commit 024a49c

Please sign in to comment.