Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backport flatCallTracer #895

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

draganm
Copy link

@draganm draganm commented Jul 10, 2024

1. Purpose or design rationale of this PR

Backport of flatCallTracer added in Geth 1.11.3

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@draganm draganm force-pushed the backport-flatcall-tracer branch 3 times, most recently from f6d7e1c to 65dda8e Compare July 17, 2024 10:57
@draganm draganm marked this pull request as ready for review July 17, 2024 11:02
@HAOYUatHZ HAOYUatHZ self-requested a review July 31, 2024 05:22
HAOYUatHZ
HAOYUatHZ previously approved these changes Jul 31, 2024
Copy link
Member

@HAOYUatHZ HAOYUatHZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have compared with flat call tracer on upstream
overall looks good, just some nitpicks

Dragan Milic and others added 2 commits August 13, 2024 10:01
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
@MRabenda
Copy link

@HAOYUatHZ @omerfirmak anything else required to merge this PR?

@omerfirmak omerfirmak merged commit 972fe8a into scroll-tech:develop Aug 23, 2024
8 checks passed
@achmand achmand deleted the backport-flatcall-tracer branch August 23, 2024 07:35
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants