Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EcMul gadget #600

Merged
merged 77 commits into from
Jul 20, 2023
Merged

EcMul gadget #600

merged 77 commits into from
Jul 20, 2023

Conversation

darth-cy
Copy link

@darth-cy darth-cy commented Jul 6, 2023

Description

Execution state gadget for EcMul precompile call.
Entry plug for EVM circuit into ECC lookup table for EcMul.

Issue Link

Closes #595

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@roynalnaruto
precompile io table definition
9481eac
@roynalnaruto
chore: ecc circuit (pre-req)
29a2fec
@roynalnaruto
chore: more witness data structs
281d2b4
@roynalnaruto
wip: assignment to the ecc circuit
01c5675
@roynalnaruto
wip: pairing ops
bb8797f
@roynalnaruto
wip
46fc712
@roynalnaruto
wip: assigned values to ecadd, ecmul
6e4bb53
@roynalnaruto
wip: assigned ec ops
ea94e95
@roynalnaruto
wip: expose ecc table
344b269
@roynalnaruto
chore: refactor
5f54a39
@roynalnaruto
chore: docs
c8709c2
@roynalnaruto
ecc table dev load
8204a9c
@roynalnaruto
pairing op bytes
e9b4291
@roynalnaruto
chore: refactor to_bytes for pairing op
96e2b3c
@roynalnaruto
Merge branch 'develop' into feat/ec-ops
f1cfcbc
@roynalnaruto
add ecc table to evm circuit
7fb66c0
@roynalnaruto
wip: test structure for ecc circuit
31b6313
@roynalnaruto
add unequal or double
e7a2869
@roynalnaruto
tests for ecc circuit
c5fc03b
@roynalnaruto
random values in tests (ecc circuit)
b94720f
@roynalnaruto
Merge branch 'develop' into feat/ec-ops
a4db5b8
@roynalnaruto
fix: compilation
a7c17a9
@roynalnaruto
fix: minor fixes
a7e00cc
@roynalnaruto
fix: pairing op assert success value
7da11e7
@roynalnaruto
chore: remove part not required
1d65c49
@roynalnaruto
Merge branch 'develop' into feat/ec-ops
e69a6f2
@roynalnaruto
Merge branch 'develop' into feat/ec-ops
5fd2b5a
@roynalnaruto
Merge branch 'develop' into feat/ec-ops
e7cf656
@roynalnaruto
fix: compilation
df8f61c
@roynalnaruto
fix: docs for ecc table args
22b729b
@roynalnaruto roynalnaruto mentioned this pull request Jul 15, 2023
Merged
11 tasks
roynalnaruto
roynalnaruto requested changes Jul 18, 2023
View reviewed changes
Copy link

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a preliminary pass

zkevm-circuits/src/evm_circuit/execution/precompiles/ec_mul.rs Outdated Show resolved Hide resolved
zkevm-circuits/src/evm_circuit/execution/precompiles/ec_mul.rs Show resolved Hide resolved
zkevm-circuits/src/evm_circuit/execution/precompiles/ec_mul.rs Outdated Show resolved Hide resolved
zkevm-circuits/src/evm_circuit/execution/precompiles/ec_mul.rs Outdated Show resolved Hide resolved
Base automatically changed from feat/ec-ops to develop July 18, 2023 15:27
@roynalnaruto roynalnaruto marked this pull request as ready for review July 19, 2023 10:18
@roynalnaruto roynalnaruto requested a review from lispc July 19, 2023 10:18
roynalnaruto
roynalnaruto approved these changes Jul 20, 2023
View reviewed changes
Copy link

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

lispc
lispc approved these changes Jul 20, 2023
View reviewed changes
Copy link

@lispc lispc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except several comments

@lispc
Copy link

lispc commented Jul 20, 2023

ok this can be merged after ci passes

@roynalnaruto roynalnaruto merged commit b348d3f into develop Jul 20, 2023
16 checks passed
@roynalnaruto roynalnaruto deleted the feat/ec-mul branch July 20, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roynalnaruto roynalnaruto roynalnaruto approved these changes

@lispc lispc lispc approved these changes

Assignees

@darth-cy darth-cy

Labels
crate-bus-mapping crate-zkevm-circuits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EcMul Execution State Validation
3 participants
@darth-cy @lispc @roynalnaruto