Skip CSI driver creation for empty SO_CSI_DRIVER_PATH in deploy release script #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scylla-operator-bot
bot
added
kind/bug
tnozicka
reviewed
Jun 25, 2024
rzetelskik
force-pushed
the
release-skip-csi-driver
branch
from
1f760e8
to
b392eb9
Compare
rzetelskik
changed the title
tnozicka
requested changes
Jun 25, 2024
rzetelskik
force-pushed
the
release-skip-csi-driver
branch
2 times, most recently
from
0d6fe19
to
1a62e26
Compare
scylla-operator-bot
bot
added
size/S
rzetelskik
force-pushed
the
release-skip-csi-driver
branch
2 times, most recently
from
eae3009
to
41c12b5
Compare
rzetelskik
force-pushed
the
release-skip-csi-driver
branch
2 times, most recently
from
da32a41
to
b470e8e
Compare
tnozicka
reviewed
Jun 26, 2024
rzetelskik
force-pushed
the
release-skip-csi-driver
branch
from
b470e8e
to
5d8e5b9
Compare
scylla-operator-bot
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
scylla-operator-bot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Currently ci-deploy-release script times out waiting for local-csi-driver to roll out, despite
SO_CSI_DRIVER_PATHbeing empty.https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/logs/ci-scylla-operator-latest-e2e-gke-arm64-serial/1805169160804634624#1:test-build-log.txt%3A306
From my understanding the intention was to always run the given revision of local-csi-driver example manifests, since, contrary to the regular deploy script, the release deploy script doesn't account forSO_CSI_DRIVER_PATHwhatsoever.Hence this PR skips local-csi-driver creation together with NodeConfig creation when emptySO_NODECONFIG_PATHis provided. We can always make it more granular if we need to deploy local-csi-driver without configuring a NodeConfig, but for now that seems good enough.Edit: local-csi-driver path can now be overridden by setting SO_CSI_DRIVER_PATH. In case the env var is empty, local-csi-driver deployment is skipped.
Which issue is resolved by this Pull Request:
Resolves #1987
/kind bug
/priority important-soon
/cc tnozicka