Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a deploy directory per kubeconfig in CI release scripts #2020

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Create a deploy directory per kubeconfig in CI release scripts #2020

merged 1 commit into from
Jul 15, 2024

Conversation

rzetelskik
Copy link
Member

Description of your changes: This PR modifies the CI release scripts to create a deploy directory per kubeconfig to support multiple kubeconfigs used in multi-datacenter tests.

Which issue is resolved by this Pull Request:
Resolves #2019

/kind bug
/priority important-soon

@scylla-operator-bot scylla-operator-bot bot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2024
tnozicka
tnozicka reviewed Jul 15, 2024
View reviewed changes
hack/ci-deploy-release.sh Outdated Show resolved Hide resolved
@rzetelskik rzetelskik force-pushed the ci-deploy-release-multi-dc-fix branch from 3b8dc7f to c591da4 Compare July 15, 2024 12:13
@rzetelskik rzetelskik requested a review from tnozicka July 15, 2024 12:13
tnozicka
tnozicka approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel-clusterip c591da4 link unknown /test e2e-gke-parallel-clusterip
ci/prow/e2e-gke-parallel c591da4 link unknown /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

looks like apiserver issues
/retest

@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel c591da4 link true /test e2e-gke-parallel
ci/prow/e2e-gke-parallel-clusterip c591da4 link true /test e2e-gke-parallel-clusterip
Full PR test history. Your PR dashboard.

/test images
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 3b9357e into scylladb:master Jul 15, 2024
13 checks passed
@rzetelskik rzetelskik deleted the ci-deploy-release-multi-dc-fix branch July 15, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

@zimnx zimnx Awaiting requested review from zimnx

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI release scripts do not support multiple kubeconfigs
2 participants
@rzetelskik @tnozicka