Use identical file system for node tuning and keep symlinks working #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnozicka
added
kind/bug
scylla-operator-bot
bot
added
the
do-not-merge/work-in-progress
scylla-operator-bot
bot
added
approved
tnozicka
force-pushed
the
fix-node-tuning-symlinks
branch
from
fee7c30
to
aca7a12
Compare
tnozicka
force-pushed
the
fix-node-tuning-symlinks
branch
from
aca7a12
to
f97d359
Compare
tnozicka
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
rzetelskik
reviewed
Jul 24, 2024
scylla-operator-bot
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
When the Kubernetes node file system contains top level symlinks our node setup fails to resolve them in the chroot. This is because we skip bind mounting some directories, like
/varand other top level dirs can be symlinks pointing there. (This is a majority of top level dirs on Core OS and immutable filesystems.)To keep top level symlinks for node setup working we need to create an identical filesystem structure. This will also clean up the overrides we have.
Which issue is resolved by this Pull Request:
Resolves #2029