Fix infinite loop in tuning between sync timeout and cri client backoff #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnozicka
added
kind/bug
scylla-operator-bot
bot
added
the
size/S
scylla-operator-bot
bot
added
the
approved
|
#1028 (comment) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Controllers shouldn't actively wait and NodeConfig's sync loop has a context limited to 30s to enforce it. Unfortunately, the cri client doesn't have a backoff configured and the default is higher (2m) which means that when reached it will keep failing new connections and wait for a backoff that's impossible to wait for with a shorter context, nor desired to wait that long in the controller sync loop.
This PR limits the cri client backoff max to be lower then the sync loop timeout and more responsive in general.
Which issue is resolved by this Pull Request:
Resolves #2057