Substitute unbound SO_SCYLLACLUSTER_STORAGECLASS_NAME var in ci-deploy script #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scylla-operator-bot
bot
added
kind/bug
scylla-operator-bot
bot
added
the
size/XS
tnozicka
reviewed
Aug 7, 2024
rzetelskik
changed the title
scylla-operator-bot
bot
added
the
do-not-merge/work-in-progress
rzetelskik
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
scylla-operator-bot
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
scylla-operator-bot
bot
added
the
approved
tnozicka
added
kind/machinery
#1426 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes: In cases where SO_SCYLLACLUSTER_STORAGECLASS_NAME is unbound, hack/ci-deploy.sh script will now fail with an error:
This is not the intended behaviour and it now requires providing the value explicitly, which is not the intended behaviour.
This PR substitutes that variable, so that the default intended behaviour is executed for an unset var.
Which issue is resolved by this Pull Request:
Resolves #
/kind bug
/priority important-longterm