Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect, snapshot and gracefully restore global objects in e2e test #2091

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Aug 23, 2024

Description of your changes:
This PR extends our e2e framework to be able to snapshot, collect and restore global resources like NodeConfigs or ScyllaOperator configs. This is very important to be able to debug the disruptive serial suites that use the same object in multiple tests and the final dump just shows the last test.

This also no longer requires the NodeConfig or Resource quotas to be missing before running the e2e suite an depending on the cleanup policy and whether the object has existed before, it will be restored after the test. This also help not to mess up local setups too much but more importantly it allows you to specify a cleanup policy to avoid deleting e.g. the NodeConfig used during the test.

Also this hooks extra dumps for the artifacts dir, e.g. e2e/cluster-0/cluster-scoped-per-ns/e2e-test-nodesetup-q6bhx-0-d7s4w/cluster-scoped/nodeconfigs.scylla.scylladb.com/cluster.yaml

Which issue is resolved by this Pull Request:
Resolves #2045

Requires

@tnozicka tnozicka added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. labels Aug 23, 2024
Copy link
Contributor

@tnozicka: GitHub didn't allow me to request PR reviews from the following users: tnozicka.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 23, 2024
@tnozicka tnozicka force-pushed the e2e-collect-global branch 5 times, most recently from 187101c to 4dc34ec Compare August 27, 2024 18:25
@tnozicka tnozicka changed the title [WIP] Collect, snapshot and gracefully restore global objects in e2e test Collect, snapshot and gracefully restore global objects in e2e test Aug 27, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@tnozicka tnozicka changed the title Collect, snapshot and gracefully restore global objects in e2e test [WIP] Collect, snapshot and gracefully restore global objects in e2e test Aug 27, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@tnozicka tnozicka force-pushed the e2e-collect-global branch 5 times, most recently from 962999d to 11397a7 Compare August 28, 2024 17:02
@tnozicka tnozicka changed the title [WIP] Collect, snapshot and gracefully restore global objects in e2e test Collect, snapshot and gracefully restore global objects in e2e test Aug 28, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2024
@tnozicka
Copy link
Member Author

/hold
for #2101

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
pkg/cmd/tests/options.go Outdated Show resolved Hide resolved
test/e2e/framework/framework.go Outdated Show resolved Hide resolved
test/e2e/framework/framework.go Show resolved Hide resolved
test/e2e/framework/cleanup.go Outdated Show resolved Hide resolved
@tnozicka tnozicka force-pushed the e2e-collect-global branch 2 times, most recently from eba1799 to 24934e6 Compare August 29, 2024 10:28
@tnozicka
Copy link
Member Author

/hold cancel
#2101 landed

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@tnozicka tnozicka force-pushed the e2e-collect-global branch 2 times, most recently from 91f72e2 to eb98043 Compare August 29, 2024 10:49
test/e2e/framework/cleanup.go Outdated Show resolved Hide resolved
test/e2e/framework/cleanup.go Show resolved Hide resolved
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign rzetelskik

Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rzetelskik
Copy link
Member

@tnozicka: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel-clusterip 00a1223 link true /test e2e-gke-parallel-clusterip
Full PR test history. Your PR dashboard.

#2061 (comment)
known manager flake
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 80c490c into scylladb:master Aug 29, 2024
13 checks passed
@tnozicka tnozicka deleted the e2e-collect-global branch August 30, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serial e2e needs storage but requires the nodeconfig that sets it up to be removed
3 participants