Add ListPackages case w/slashes in root path

Not covering this basic aspect of how real project roots actually work
allowed a windows bug to hide until real data came through - #146.

_testdata/src/github.com/example/varied/locals.go

@@ -0,0 +1,13 @@
+package main
+
+import (
+	"github.com/example/varied/namemismatch"
+	"github.com/example/varied/otherpath"
+	"github.com/example/varied/simple"
+)
+
+var (
+	_ = simple.S
+	_ = nm.V
+	_ = otherpath.O
+)

_testdata/src/github.com/example/varied/m1p/a.go

@@ -0,0 +1,12 @@
+package m1p
+
+import (
+	"sort"
+
+	"github.com/sdboyer/gps"
+)
+
+var (
+	M = sort.Strings
+	_ = gps.Solve
+)

_testdata/src/github.com/example/varied/m1p/b.go

@@ -0,0 +1,11 @@
+package m1p
+
+import (
+	"os"
+	"sort"
+)
+
+var (
+	_ = sort.Strings
+	_ = os.PathSeparator
+)

_testdata/src/github.com/example/varied/main.go

@@ -0,0 +1,9 @@
+package main
+
+import (
+	"net/http"
+)
+
+var (
+	_ = http.Client
+)

_testdata/src/github.com/example/varied/namemismatch/nm.go

@@ -0,0 +1,12 @@
+package nm
+
+import (
+	"os"
+
+	"github.com/Masterminds/semver"
+)
+
+var (
+	V = os.FileInfo
+	_ = semver.Constraint
+)

_testdata/src/github.com/example/varied/otherpath/otherpath_test.go

@@ -0,0 +1,5 @@
+package otherpath
+
+import "github.com/example/varied/m1p"
+
+var O = m1p.M

_testdata/src/github.com/example/varied/simple/another/another.go

@@ -0,0 +1,7 @@
+package another
+
+import "hash"
+
+var (
+	H = hash.Hash
+)

_testdata/src/github.com/example/varied/simple/another/another_test.go

@@ -0,0 +1,7 @@
+package another
+
+import "encoding/binary"
+
+var (
+	_ = binary.PutVarint
+)

_testdata/src/github.com/example/varied/simple/another/locals.go

@@ -0,0 +1,5 @@
+package another
+
+import "github.com/example/varied/m1p"
+
+var _ = m1p.M

_testdata/src/github.com/example/varied/simple/locals.go

@@ -0,0 +1,7 @@
+package simple
+
+import "github.com/example/varied/simple/another"
+
+var (
+	_ = another.H
+)

_testdata/src/github.com/example/varied/simple/simple.go

@@ -0,0 +1,12 @@
+package simple
+
+import (
+	"go/parser"
+
+	"github.com/sdboyer/gps"
+)
+
+var (
+	_ = parser.ParseFile
+	S = gps.Prepare
+)

analysis_test.go

@@ -913,7 +913,7 @@ func TestListPackages(t *testing.T) {
 
 func TestListExternalImports(t *testing.T) {
 	// There's enough in the 'varied' test case to test most of what matters
-	vptree, err := ListPackages(filepath.Join(getwd(t), "_testdata", "src", "varied"), "varied")
+	vptree, err := ListPackages(filepath.Join(getwd(t), "_testdata", "src", "github.com", "example", "varied"), "github.com/example/varied")
 	if err != nil {
 		t.Fatalf("listPackages failed on varied test case: %s", err)
 	}
@@ -999,15 +999,15 @@ func TestListExternalImports(t *testing.T) {
 	// should have the same effect as ignoring main
 	name = "ignore the root"
 	ignore = map[string]bool{
-		"varied": true,
+		"github.com/example/varied": true,
 	}
 	except("net/http")
 	validate()
 
 	// now drop a more interesting one
 	name = "ignore simple"
 	ignore = map[string]bool{
-		"varied/simple": true,
+		"github.com/example/varied/simple": true,
 	}
 	// we get github.com/sdboyer/gps from m1p, too, so it should still be there
 	except("go/parser")
@@ -1016,8 +1016,8 @@ func TestListExternalImports(t *testing.T) {
 	// now drop two
 	name = "ignore simple and namemismatch"
 	ignore = map[string]bool{
-		"varied/simple":       true,
-		"varied/namemismatch": true,
+		"github.com/example/varied/simple":       true,
+		"github.com/example/varied/namemismatch": true,
 	}
 	except("go/parser", "github.com/Masterminds/semver")
 	validate()
@@ -1041,8 +1041,8 @@ func TestListExternalImports(t *testing.T) {
 	// ignore two that should knock out gps
 	name = "ignore both importers"
 	ignore = map[string]bool{
-		"varied/simple": true,
-		"varied/m1p":    true,
+		"github.com/example/varied/simple": true,
+		"github.com/example/varied/m1p":    true,
 	}
 	except("sort", "github.com/sdboyer/gps", "go/parser")
 	validate()
@@ -1072,7 +1072,7 @@ func TestListExternalImports(t *testing.T) {
 
 func TestExternalReach(t *testing.T) {
 	// There's enough in the 'varied' test case to test most of what matters
-	vptree, err := ListPackages(filepath.Join(getwd(t), "_testdata", "src", "varied"), "varied")
+	vptree, err := ListPackages(filepath.Join(getwd(t), "_testdata", "src", "github.com", "example", "varied"), "github.com/example/varied")
 	if err != nil {
 		t.Fatalf("listPackages failed on varied test case: %s", err)
 	}
@@ -1108,12 +1108,12 @@ func TestExternalReach(t *testing.T) {
 	}
 
 	all := map[string][]string{
-		"varied":                {"encoding/binary", "github.com/Masterminds/semver", "github.com/sdboyer/gps", "go/parser", "hash", "net/http", "os", "sort"},
-		"varied/m1p":            {"github.com/sdboyer/gps", "os", "sort"},
-		"varied/namemismatch":   {"github.com/Masterminds/semver", "os"},
-		"varied/otherpath":      {"github.com/sdboyer/gps", "os", "sort"},
-		"varied/simple":         {"encoding/binary", "github.com/sdboyer/gps", "go/parser", "hash", "os", "sort"},
-		"varied/simple/another": {"encoding/binary", "github.com/sdboyer/gps", "hash", "os", "sort"},
+		"github.com/example/varied":                {"encoding/binary", "github.com/Masterminds/semver", "github.com/sdboyer/gps", "go/parser", "hash", "net/http", "os", "sort"},
+		"github.com/example/varied/m1p":            {"github.com/sdboyer/gps", "os", "sort"},
+		"github.com/example/varied/namemismatch":   {"github.com/Masterminds/semver", "os"},
+		"github.com/example/varied/otherpath":      {"github.com/sdboyer/gps", "os", "sort"},
+		"github.com/example/varied/simple":         {"encoding/binary", "github.com/sdboyer/gps", "go/parser", "hash", "os", "sort"},
+		"github.com/example/varied/simple/another": {"encoding/binary", "github.com/sdboyer/gps", "hash", "os", "sort"},
 	}
 	// build a map to validate the exception inputs. do this because shit is
 	// hard enough to keep track of that it's preferable not to have silent
@@ -1190,13 +1190,13 @@ func TestExternalReach(t *testing.T) {
 	// turn off main pkgs, which necessarily doesn't affect anything else
 	name = "no main"
 	main = false
-	except("varied")
+	except("github.com/example/varied")
 	validate()
 
 	// ignoring the "varied" pkg has same effect as disabling main pkgs
 	name = "ignore root"
 	ignore = map[string]bool{
-		"varied": true,
+		"github.com/example/varied": true,
 	}
 	main = true
 	validate()
@@ -1208,20 +1208,20 @@ func TestExternalReach(t *testing.T) {
 	tests = false
 	ignore = nil
 	except(
-		"varied encoding/binary",
-		"varied/simple encoding/binary",
-		"varied/simple/another encoding/binary",
-		"varied/otherpath github.com/sdboyer/gps os sort",
+		"github.com/example/varied encoding/binary",
+		"github.com/example/varied/simple encoding/binary",
+		"github.com/example/varied/simple/another encoding/binary",
+		"github.com/example/varied/otherpath github.com/sdboyer/gps os sort",
 	)
 
 	// almost the same as previous, but varied just goes away completely
 	name = "no main or tests"
 	main = false
 	except(
-		"varied",
-		"varied/simple encoding/binary",
-		"varied/simple/another encoding/binary",
-		"varied/otherpath github.com/sdboyer/gps os sort",
+		"github.com/example/varied",
+		"github.com/example/varied/simple encoding/binary",
+		"github.com/example/varied/simple/another encoding/binary",
+		"github.com/example/varied/otherpath github.com/sdboyer/gps os sort",
 	)
 	validate()
 
@@ -1232,38 +1232,38 @@ func TestExternalReach(t *testing.T) {
 	// varied/simple
 	name = "ignore varied/simple"
 	ignore = map[string]bool{
-		"varied/simple": true,
+		"github.com/example/varied/simple": true,
 	}
 	except(
 		// root pkg loses on everything in varied/simple/another
-		"varied hash encoding/binary go/parser",
-		"varied/simple",
+		"github.com/example/varied hash encoding/binary go/parser",
+		"github.com/example/varied/simple",
 	)
 	validate()
 
 	// widen the hole by excluding otherpath
 	name = "ignore varied/{otherpath,simple}"
 	ignore = map[string]bool{
-		"varied/otherpath": true,
-		"varied/simple":    true,
+		"github.com/example/varied/otherpath": true,
+		"github.com/example/varied/simple":    true,
 	}
 	except(
 		// root pkg loses on everything in varied/simple/another and varied/m1p
-		"varied hash encoding/binary go/parser github.com/sdboyer/gps sort",
-		"varied/otherpath",
-		"varied/simple",
+		"github.com/example/varied hash encoding/binary go/parser github.com/sdboyer/gps sort",
+		"github.com/example/varied/otherpath",
+		"github.com/example/varied/simple",
 	)
 	validate()
 
 	// remove namemismatch, though we're mostly beating a dead horse now
 	name = "ignore varied/{otherpath,simple,namemismatch}"
-	ignore["varied/namemismatch"] = true
+	ignore["github.com/example/varied/namemismatch"] = true
 	except(
 		// root pkg loses on everything in varied/simple/another and varied/m1p
-		"varied hash encoding/binary go/parser github.com/sdboyer/gps sort os github.com/Masterminds/semver",
-		"varied/otherpath",
-		"varied/simple",
-		"varied/namemismatch",
+		"github.com/example/varied hash encoding/binary go/parser github.com/sdboyer/gps sort os github.com/Masterminds/semver",
+		"github.com/example/varied/otherpath",
+		"github.com/example/varied/simple",
+		"github.com/example/varied/namemismatch",
 	)
 	validate()
 }