Can't use phantomjs.cli.args in webDriverCapabilities

[klieber]

Looking at the source code of org.openqa.selenium.phantomjs.PhantomJSDriverService#findCLIArgumentsFromCaps, it seems that it expects the capability to be in the form of either String[] or a Collection. As the type passed by jasmine-maven-plugin is always String, this test will always fail and thus it is not currently possible to specify phantomjs.cli.args.

This could perhaps be seen as a bug in PhantomJSDriverService, which should allow a String to be used as a single argument.

[tomdw]

Same problem here. We are trying to solve a problem with phantomjs on our build server and having the ability to activate the debug logging of phantomjs seems desirable. Using the jasmine-maven-plugin this would require to pass phantomjs.cli.args but this does not work.

[klieber]

I've decided to make a non backwards compatible change to the format of the webDriverCapabilities parameter to support this functionality.

This is an example configuration using the new format with phantomjs.cli.args:

<plugin>
  <groupId>com.github.searls</groupId>
  <artifactId>jasmine-maven-plugin</artifactId>
  <version>${jasmine-maven-plugin.version}</version>
  <executions>
    <execution>
      <goals>
        <goal>test</goal>
      </goals>
    </execution>
  </executions>
  <configuration>
    <webDriverClassName>org.openqa.selenium.phantomjs.PhantomJSDriver</webDriverClassName>
    <webDriverCapabilities>
      <capability>
        <name>phantomjs.cli.args</name>
        <list>
          <value>--disk-cache=true</value>
          <value>--max-disk-cache-size=256</value>
        </list>
      </capability>
    </webDriverCapabilities>
  </configuration>
</plugin>

This will be more fully documented in the plugin documentation when it is releases.

[coveralls]

Coverage decreased (-0.73%) when pulling 45edff1 on klieber:issue/200_web_driver_capabilities into c45b873 on searls:master.

[coveralls]

Coverage decreased (-0.73%) when pulling 72c52bd on klieber:issue/200_web_driver_capabilities into c45b873 on searls:master.