Skip to content

Commit

Permalink
Bump dependencies (so that users that install using Composer's --pref…
Browse files Browse the repository at this point in the history 
…er-lowest CLI option also get recent versions)
  • Loading branch information
@sebastianbergmann
sebastianbergmann committed Jul 9, 2024
1 parent 2f06a16 commit 5c0a514
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
28 changes: 14 additions & 14 deletions composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,22 @@
"ext-mbstring": "*",
"ext-xml": "*",
"ext-xmlwriter": "*",
"doctrine/instantiator": "^1.3.1",
"myclabs/deep-copy": "^1.10.0",
"phar-io/manifest": "^2.0.3",
"phar-io/version": "^3.0.2",
"phpunit/php-code-coverage": "^7.0.12",
"phpunit/php-file-iterator": "^2.0.4",
"doctrine/instantiator": "^1.5.0",
"myclabs/deep-copy": "^1.12.0",
"phar-io/manifest": "^2.0.4",
"phar-io/version": "^3.2.1",
"phpunit/php-code-coverage": "^7.0.17",
"phpunit/php-file-iterator": "^2.0.6",
"phpunit/php-text-template": "^1.2.1",
"phpunit/php-timer": "^2.1.2",
"phpunit/php-timer": "^2.1.4",
"sebastian/comparator": "^3.0.5",
"sebastian/diff": "^3.0.2",
"sebastian/environment": "^4.2.3",
"sebastian/exporter": "^3.1.5",
"sebastian/global-state": "^3.0.0",
"sebastian/object-enumerator": "^3.0.3",
"sebastian/resource-operations": "^2.0.1",
"sebastian/type": "^1.1.3",
"sebastian/diff": "^3.0.6",
"sebastian/environment": "^4.2.5",
"sebastian/exporter": "^3.1.6",
"sebastian/global-state": "^3.0.5",
"sebastian/object-enumerator": "^3.0.5",
"sebastian/resource-operations": "^2.0.3",
"sebastian/type": "^1.1.5",
"sebastian/version": "^2.0.1"
},
"config": {
Expand Down
2 changes: 1 addition & 1 deletion composer.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 comments on commit 5c0a514

@staabm
Copy link
Contributor

@staabm staabm commented on 5c0a514 Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the detailed commit message. I find the sentiment interessting.

was there a particular "error"/problem which motivated this change?
I would expect someone using "prefer-lowest" to get the oldest possible combination of dependencies which still work.
if the composer.json/lock before this commit did not work for some reason, I would expect phpunits CI to fail.

@sebastianbergmann
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"[T]he oldest possible combination of dependencies" still worked before this commit, but caused deprecation warnings with PHP 8.4-dev. This was brought up by @lolli42 in #5893.

@staabm
Copy link
Contributor

@staabm staabm commented on 5c0a514 Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. does this mean it would be helpful to have a phpunit prefer lowest ci build which errors on deprecation warnings?

@sebastianbergmann
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider using testing with --prefer-lowest a waste of resources.

Please sign in to comment.