networkInterfaces() fixed Windows XP bug (WMIC NetEnabled)

sebhildebrandt · May 5, 2021 · f8addf6 · f8addf6
1 parent 2fba3e9
commit f8addf6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,7 @@ For major (breaking) changes - version 3 and 2 see end of page.
 
 | Version        | Date           | Comment  |
 | -------------- | -------------- | -------- |
+| 4.34.23        | 2021-05-05     | `networkInterfaces()` fixed Windows XP bug (WMIC NetEnabled) |
 | 4.34.22        | 2021-05-05     | restored Node 4.x compatibility |
 | 4.34.21        | 2021-05-04     | `dockerContainerInspect()`, `dockerContainerProcesses()` parameter validation fix |
 | 4.34.20        | 2021-04-08     | `versions()` parameter validation |

diff --git a/lib/network.js b/lib/network.js
@@ -239,7 +239,7 @@ function parseLinesWindowsNics(sections, nconfigsections) {
 }
 
 function getWindowsNics() {
-  const cmd = util.getWmic() + ' nic get MACAddress, name, NetEnabled, Speed, NetConnectionStatus, AdapterTypeId /value';
+  const cmd = util.getWmic() + ' nic get /value';
   const cmdnicconfig = util.getWmic() + ' nicconfig get dhcpEnabled /value';
   try {
     const nsections = execSync(cmd, util.execOptsWin).split(/\n\s*\n/);