Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Update secret not found error message #172

Merged
merged 9 commits into from
Mar 18, 2020
Merged

Update secret not found error message #172

merged 9 commits into from
Mar 18, 2020

Conversation

Marton6
Copy link
Member

@Marton6 Marton6 commented Feb 25, 2020 •
edited
Loading

The secret not found error will now include the path of the secret. For example:

Encountered an error: cannot find secret: test/test/test, encountered error: Repo not found (server.repo_not_found)  (client.secret_not_found)

@Marton6 Marton6 marked this pull request as ready for review February 26, 2020 16:24
SimonBarendse
SimonBarendse reviewed Feb 26, 2020
View reviewed changes
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to make this available for all usage of secrets 😄

I've some suggestions and a question about the impact of this change.

pkg/secrethub/secret_version.go Outdated Show resolved Hide resolved
pkg/secrethub/secret_version.go Outdated Show resolved Hide resolved
pkg/secrethub/secret_version.go Outdated Show resolved Hide resolved
pkg/secrethub/secret_version.go Outdated Show resolved Hide resolved
@SimonBarendse @golangcibot
goimports
0cc8bde 
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
@SimonBarendse @golangcibot
gofmt
f0950a7 
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
@SimonBarendse @golangcibot
gofmt
b6684c0 
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
@Marton6
Copy link
Member Author

Marton6 commented Mar 15, 2020

This PR requires the go version of the client to be updated to 1.13

@SimonBarendse SimonBarendse merged commit 340f69a into develop Mar 18, 2020
@SimonBarendse SimonBarendse deleted the feature/improved-secret-not-found-error branch March 18, 2020 21:46
@SimonBarendse SimonBarendse mentioned this pull request Mar 23, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mackenbach mackenbach mackenbach left review comments

@golangcibot golangcibot golangcibot left review comments

@SimonBarendse SimonBarendse SimonBarendse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Marton6 @mackenbach @SimonBarendse @golangcibot