This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Add secret path to all secret not found errors #183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return
errSecretNotFound
from bothSecretVersionService
when secrets are listed andSecretService
when get method is called.The goal of this PR is to make the client always return
errSecretNotFound
when a secret is not found as opposed to a server error (ErrSecretNotFound
) when listing secret versions and getting secrets and the client error:errSecretNotFound
when getting secret versions.