This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Fix error handling of credential loading #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old behaviour of ignoring the error, resulted in errors during loading a credential (for example, a wrong passphrase), from being ignored. This resulted in getting an "unauthenticated client" error. Creating an unauthenticated client is no longer needed now that the signup process is removed from the SDK and CLI.
This is no longer necessary because the environment variable is already checked in the decryption logic. By removing the default passphraseReader, it is also easier to determine if a passphrase has been explicitly set by just checking if the passphraseReader is nil.
Without this statement, you'd get an error about the message authentication of the encrypted credential being invalid. That's not really useful.
This test created a normal client without having a credential available. By decoupling the tested functionality from NewClient, the credential loading functionality is no longer triggered and this error is avoided.
SimonBarendse
approved these changes
Feb 8, 2021
SimonBarendse
approved these changes
Feb 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two cases where either no error or an useless error were returned in the process of loading a credential:
passphraseReaderis nownilagain in all cases that no passphrase is provided)